Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for que name to Que adapter. #38635

Merged
merged 1 commit into from
Mar 4, 2020
Merged

Add support for que name to Que adapter. #38635

merged 1 commit into from
Mar 4, 2020

Conversation

morgoth
Copy link
Member

@morgoth morgoth commented Mar 4, 2020

This rebases and fixes #32157 (should preserve original author as co-author)
Also resolves que-rb/que#266

/cc @eileencodes as you asked for rebase some time ago

@rails-bot rails-bot bot added the activejob label Mar 4, 2020
@morgoth @bnauta
Add support for que name to Que adapter.
d12a31b 
Co-authored-by: Brad Nauta <bradnauta@gmail.com>
@eileencodes
Copy link
Member

Can you fix the Rubocop build?

activejob/test/support/integration/adapters/que.rb:28:23: C: Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
        Que::Job.work('integration_tests')
                      ^^^^^^^^^^^^^^^^^^^

@morgoth
Copy link
Member Author

morgoth commented Mar 4, 2020

@eileencodes Rubocop is fixed. The test failures look like unrelated to this changes

@eileencodes eileencodes merged commit 4b4f6b8 into rails:master Mar 4, 2020
@eileencodes
Copy link
Member

Thanks @morgoth!

@morgoth
Copy link
Member Author

morgoth commented Mar 4, 2020

Thanks. Can we have a backport to 6-0-stable please?

eileencodes added a commit that referenced this pull request Mar 4, 2020
@eileencodes
Merge pull request #38635 from tiramizoo/que-queue-name
1f07579 
Add support for que name to Que adapter.
@eileencodes
Copy link
Member

Done!

This was referenced Apr 4, 2020
Closed
Merged
@hlascelles hlascelles mentioned this pull request May 10, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
activejob
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Named queues don't work in ActiveJob
2 participants
@morgoth @eileencodes